Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GuardedMulticaller2 Multicall Typehash #245

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Update GuardedMulticaller2 Multicall Typehash #245

merged 2 commits into from
Sep 11, 2024

Conversation

hiep-immutable
Copy link
Contributor

There is a typo in MULTICALL_TYPEHASH that we should fix. This does not affect the behavior of the contract. It would, however, affect how the signature should be generated off-chain. Considering no one has used the contract, we would prefer to fix this issue.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Sep 6, 2024 •
edited
Loading

Update GuardedMulticaller2 Multicall Typehash

Generated at commit: 902d30c01063b445c3e93028b6965793aecef15c

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
0
0
11
27
40
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@hiep-immutable hiep-immutable requested a review from a team as a code owner September 11, 2024 00:21
@hiep-immutable hiep-immutable merged commit 9e1d397 into main Sep 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allan-almeida-imtbl allan-almeida-imtbl allan-almeida-imtbl approved these changes

@ipekt ipekt ipekt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiep-immutable @ipekt @allan-almeida-imtbl